Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let some scrollbars have out of range values #3252 #115

Conversation

teeworlds-mirror
Copy link
Collaborator

This is necessary because options like mouse sensivity get replaced with their scrollbar max value every time you open their settings page.
ChillerDragon
ChillerDragon previously approved these changes Jul 18, 2024
Copy link
Member

@ChillerDragon ChillerDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix a bug. I am in favor of merging it.

@ChillerDragon
Copy link
Member

Currently if one sets inp_mousesense 1000 that works fine in game. But that value will be clamed as soon as the user visits the settings menu where the range is rendered. Opening a menu should never change your settings!

Before the input was hard clamped at 500 now it grows the max to the current value of the config. So in the inp_mousesense 1000 example the menu now looks like this:

image

furo321
furo321 previously approved these changes Jul 18, 2024
Mainly for increasing readability and confidence when working with both sources
@ChillerDragon ChillerDragon dismissed stale reviews from furo321 and themself via 76a7f6b July 19, 2024 12:02
@ChillerDragon
Copy link
Member

Fetched new commits using ARG_DRY=0 ./mirror-bot.sh --update 3252

@jtbx jtbx enabled auto-merge July 19, 2024 21:19
@ChillerDragon ChillerDragon merged commit 66a1989 into teeworlds-community:community Jul 20, 2024
6 of 8 checks passed
@ChillerDragon
Copy link
Member

I abused org admin to force merge. We got enough approvals but the pipeline is broken. We really need to fix the macos issue #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants